bug#14303: 24.3; Bug in comment-search-backward

[Andreas Röhler]

Am 16.05.2013 06:02, schrieb Leo Liu:
> On 2013-05-16 00:13 +0800, Andreas Röhler wrote:
> > syntax-ppss is reliable, while re-search-backward comment-start-skip
> > might stop inside a string etc.
> >
> > backward-line, end-of-line
> > if nt4 and nth8, goto char nth8
> >
> > that's nearly all
> > as done consider limit of search, sure.
> >
> > Watching with interest,
> >
> > Andreas
>
> I don't know what to make of this comment. Do you see a problem in the
> patch?

Yes, same thing as with beg-of-defun discussed elsewhere.

+ (while (and (not found) (re-search-backward comment-start-skip limit t))
+      (setq end (match-end 0))
+      (or (nth 8 (syntax-ppss)) (setq found t)))

This might find a comment-start inside a string.

Rely at (syntax-ppss)

if nt4 and nth8, goto char nth8


Cheers,

Andreas
> Thanks,
> Leo