[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to
|
From: |
Stefan Monnier |
|
Subject: |
bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits |
|
Date: |
Tue, 30 Jul 2013 21:38:03 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> This fix is simple enough. Apply?
Looks good, thanks.
> The functions could also use some further cleanup:
> 1) Swap the `to' and `fr' local variables.
I think that would make sense, yes.
> 2) Extract the function bodies to one function with a third argument
> (called `whole-changeset', maybe), and make them call it.
If that can be done without too much extra code, that sounds good.
Stefan