bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"

[Michael Heerdegen]

Juanma Barranquero <lekktu@gmail.com> writes:

> FWIW, looking at the change I've had the same reaction as Drew.

Well, it was the best short formulation that came to my mind.

> The message still suggests that using make-variable-buffer-local other
> than at toplevel is erroneous.
>
> It should say something like
>
>   Use of make-variable-buffer-local other than at top-level could be
> an error; perhaps you wanted to use make-local-variable?
>
> only shortish and better redacted.

The "shortish" part is the problem.  Is it even allowed to use more than
one line?  Presumably this kind of warning would not appear to often
when you do things right, so using a longer formulation could be
justified.


Michael.