bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#13312: 24.3.50; delete selection mode not killing on overwrite


From: Juri Linkov
Subject: bug#13312: 24.3.50; delete selection mode not killing on overwrite
Date: Sun, 20 Oct 2013 00:08:45 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)

> What was the reason for introducing
> `self-insert-uses-region-functions'?  It seems it was only for
> `electric-pair-mode'.  IIRC, I wasn't too happy with that hack when
> it was done.  Now it seems to be dirtying (complicating) `delsel.el'.
> Isn't there a better way?

I think (run-hook-with-args-until-success 'self-insert-uses-region-functions)
could be moved to the body of `delete-selection-helper'.
Then the users again will enjoy the simplicity of

  (put 'self-insert-command 'delete-selection t)

and

  (put 'self-insert-command 'delete-selection 'kill)

> Sorry, I cannot judge now whether this DTRT.  But again, this seems
> to reach beyond this bug.  (Let me know if I'm missing something
> and this is really specific to this bug.)

The first hunk of my patch fixes the reported bug.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]