[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15786: 24.3; No warning on mal-formed let form when lexical-binding
From: |
Nathan Trapuzzano |
Subject: |
bug#15786: 24.3; No warning on mal-formed let form when lexical-binding |
Date: |
Sat, 02 Nov 2013 11:26:48 -0400 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) |
Nathan Trapuzzano <nbtrap@nbtrap.com> writes:
> Patch attached.
Sorry, that patch messed up with (let ((var-with-no-value-form)) ...).
Correct patch attached here.
>From 1cd7356af9caca830f4764205dcbd2f6afe4b6d3 Mon Sep 17 00:00:00 2001
From: Nathan Trapuzzano <nbtrap@nbtrap.com>
Date: Sat, 2 Nov 2013 10:12:35 -0400
Subject: [PATCH] Assert proper form of let binding during byte compilation
under lexical binding.
---
lisp/emacs-lisp/cconv.el | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el
index f24e503..3fc2fc4 100644
--- a/lisp/emacs-lisp/cconv.el
+++ b/lisp/emacs-lisp/cconv.el
@@ -289,12 +289,14 @@ places where they originally did not directly appear."
(dolist (binder binders)
(let* ((value nil)
- (var (if (not (consp binder))
- (prog1 binder (setq binder (list binder)))
- (setq value (cadr binder))
- (car binder)))
- (new-val
- (cond
+ (var (if (not (consp binder))
+ (prog1 binder (setq binder (list binder)))
+ (cl-assert (null (cdr (cdr binder))) nil
+ "malformed let binding: `%s'"
(prin1-to-string binder))
+ (setq value (cadr binder))
+ (car binder)))
+ (new-val
+ (cond
;; Check if var is a candidate for lambda lifting.
((and (member (cons binder form) cconv-lambda-candidates)
(progn
--
1.8.4.2