bug#15648: 24.2.50; gnutls SSL connection to IMAP server causes emacs to crash completely

[Eli Zaretskii]

> From: Ted Zlatanov <tzz@lifelogs.com>
> Cc: emacs@kosowsky.org,  15648@debbugs.gnu.org
> Date: Mon, 04 Nov 2013 11:44:41 -0500
> 
> EZ> If so, perhaps the problem is that we leave the process object
> EZ> marked as a GnuTLS process, but with a NULL state?  Should we remove
> EZ> the mark, or maybe delete the process object in gnutls-negotiate?
> >> 
> >> I would abort with a message like any other error.
> 
> EZ> Maybe you should install a change that does that, and see if it solves
> EZ> the problem.
> 
> You mean like this?

Something like that, yes.

> Should I have a special check for "gnutls_p is set but gnutls_state
> is NULL"?

That's what this patch does, doesn't it?  Or did I misunderstand you?

> EZ> We _begin_ by setting gnutls_state to NULL.  What could possibly
> EZ> happen is that we somehow let the process object with a NULL state
> EZ> escape from the initialization step, and then
> EZ> wait_reading_process_output stumbles on it and tries to use it,
> EZ> because the gnutls_p flag is also set right at the beginning.
> 
> EZ> How about if we set the gnutls_p flag only when the whole
> EZ> initialization succeeds completely?  It's only then that the process
> EZ> is ready to be used in conjunction with GnuTLS, isn't it?
> 
> You're absolutely right.  Can you check if this patch is good?  It looks
> OK to me.

It compiles fine.  But since I cannot reproduce the original problem,
I'd ask the OP to please see if this fixes that problem.

Thanks.