[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13594: Planning Emacs-24.4
From: |
Leo Liu |
Subject: |
bug#13594: Planning Emacs-24.4 |
Date: |
Mon, 18 Nov 2013 23:48:07 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) |
On 2013-11-18 23:20 +0800, martin rudalics wrote:
> I thought you intially wanted to fix the problem that a caller cannot
> handle a nil return value from `display-buffer'. But Stefan says that
> it's not necessary to do that and I agree with him. So your fix is OK
> but I'd just make the last line of `display-buffer' something like
>
> (when (windowp window) window)
>
> and you don't have to talk about a return value of t. Returning t sounds
> not very intuitive when a function fails to accomplish something.
OK, thank you for the quick response. I have re-worked the patch based
on Stefan's and your comments. Please review it. Thanks.
Leo
13594.diff
Description: Text Data
- bug#13594: Planning Emacs-24.4, (continued)
- bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
- bug#13594: Planning Emacs-24.4, Andreas Schwab, 2013/11/18
- bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
- bug#13594: Planning Emacs-24.4, Andreas Schwab, 2013/11/18
- bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/18
- Message not available
- bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
- bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/18
- bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
- bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/18
- bug#13594: Planning Emacs-24.4,
Leo Liu <=
- bug#13594: Planning Emacs-24.4, Stefan Monnier, 2013/11/18
- bug#13594: Planning Emacs-24.4, Juri Linkov, 2013/11/18
- bug#13594: Planning Emacs-24.4, Stefan Monnier, 2013/11/18
bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/18
bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/19
bug#13594: Planning Emacs-24.4, Leo Liu, 2013/11/19
bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/20
bug#13594: Planning Emacs-24.4, Stefan Monnier, 2013/11/18
bug#13594: Planning Emacs-24.4, martin rudalics, 2013/11/19
bug#13594: Planning Emacs-24.4, Juri Linkov, 2013/11/19