bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode)

[Anders Lindgren]

Hi Stefan!

For me, personally, I would be glad to sign a general assignment. Unfortunately, my employer does not want to sign a general sign-off agreement -- they prefer to do this case by case. (I respect this -- after all, the company I work for develop IDE:s for the embedded industry so there is a risk of conflict of interests, even though I mainly work on the compiler and not the editor.)

In this case, for isearch.el, I do not see the need for an assignment, as I only have reported bugs I have found, not contributed actual code. However, if you think it is necessary, I will sign an assignment -- hopefully we can define a scope that is acceptable to my employer, like "basic Emacs functionality".

    -- Anders

On Wed, Dec 4, 2013 at 6:57 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> I tried you solution and it works perfectly! Just make sure to save the
> keymap after the call to "(run-hooks 'isearch-mode-hook)", as this is where
> packages like "folding" installs its keymap.

Great to hear.  Juri, can you do that for me?

> While looking around the isearch code, I came up with a theory why
> multi-buffer search in change-log-mode no longer works. isearch adds its
> hook to the LOCAL pre-command-hook. As change-log-mode search change buffer
> and the hook is not installed in the new buffer, the user can't exit
> isearch.

Sounds right, as well.  Juri, can you take care of that while you're at it?

BTW, Anders, I see you have signed more paperwork for Emacs than pretty
much anybody else, yet none of them covers changes to isearch.el.
If I were you, I'd sign a general assignment for all of Emacs and be
done with it once and for all.  If that's OK with you, then just tell me
and I'll send you the relevant info,


        Stefan