[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16058: 24.3.50; X protocol error: BadAlloc...
From: |
Eli Zaretskii |
Subject: |
bug#16058: 24.3.50; X protocol error: BadAlloc... |
Date: |
Mon, 09 Dec 2013 20:15:14 +0200 |
> Date: Mon, 09 Dec 2013 21:11:50 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: thierry.volpiatto@gmail.com, 16058@debbugs.gnu.org
>
> >> + /* Don't extend on a previously drawn tool bar items (Bug#16058). */
> >> + row->enabled_p = 0;
> >> prepare_desired_row (row);
> >> row->y = it->current_y;
> >
> > Isn't it better to just call clear_glyph_row explicitly?
>
> Hm...not sure, what about enabling enabled_p
You can do that by hand.
> and preserving reversed_p?
We don't support R2L toolbars anyway, there's a comment about that in
the code.
Anyway, if you prefer to do this your way, we should have a comment
there saying that disabling the row ensures prepare_desired_row will
clear it.
> And, of course, thanks for reviewing it.
You are welcome.
- bug#16058: 24.3.50; X protocol error: BadAlloc..., (continued)
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Dmitry Antipov, 2013/12/05
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Dmitry Antipov, 2013/12/06
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Thierry Volpiatto, 2013/12/06
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Dmitry Antipov, 2013/12/09
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Eli Zaretskii, 2013/12/09
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Dmitry Antipov, 2013/12/09
- bug#16058: 24.3.50; X protocol error: BadAlloc...,
Eli Zaretskii <=
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Dmitry Antipov, 2013/12/10
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Thierry Volpiatto, 2013/12/14
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Eli Zaretskii, 2013/12/14
- bug#16058: 24.3.50; X protocol error: BadAlloc..., Thierry Volpiatto, 2013/12/14