[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15108: [Patch] Updated package dependencies
From: |
Tom Willemse |
Subject: |
bug#15108: [Patch] Updated package dependencies |
Date: |
Thu, 12 Dec 2013 20:23:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> I've tested it most recently bzr trunk revision 115470. All the ways to
>> specify dependencies work as described before:
>
> Looks good, just one nitpick:
>
>> ;; Package-Requires: foo
>> ;; Package-Requires: (foo bar)
>> ;; Package-Requires: (foo (baz "1.1.0") bar)
>> ;; Package-Requires: (baz "1.1.0")
>
> Please don't support the first form nor the last form, since it
> otherwise gives the impression that
>
> ;; Package-Requires: foo bar baz
> or
> ;; Package-Requires: (foo "0.1") (bar "2.0")
>
> will also work and we don't want to go that way.
Taken care of in attached patch. I was unsure of how to deal with these
situations, so I explicitly signal a (hopefully) clear error. Just
letting it crash on trying to get the cdr of a symbol seemed messy.
Please let me know what you think.
pkgdep.patch
Description: Another patch