|
From: | Reuben Thomas |
Subject: | bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems |
Date: | Mon, 27 Jan 2014 13:25:01 +0000 |
I could be convinced to install it if it's "obviously safe".
The patch as sent is a large chunk of "new" code plus a large chunk of
"removed" code, so it's not very appealing. Diffing while ignoring
whitespace indicates it's more of a "refactoring", and by introducing an
"artificial" new function while helps keep the text lines in the
original order (and hence helps reduce the size of the diff), I get the
patch below.
But it's not obviously safe to me. Two non-obvious parts are:
- the removal of "(add-to-list 'whitespace-style (car option))".
- the change from has-bogus to bogus-list, where bogus-list will
(initially) only be nil if whitespace-report-list is nil.
Another problem is that the docstring of whitespace-test-region does not
accurately describe its return value.
[Prev in Thread] | Current Thread | [Next in Thread] |