bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems

[Reuben Thomas]

On 28 January 2014 00:32, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> -(defun whitespace-report (&optional force report-if-bogus)
> +(defun whitespace-report (&optional force report)

I'd leave the name unchanged.  Will make for a cleaner diff and the
name "report" is not convincingly better.

Sure, OK.

 

> +If REPORT is t, it reports only when there are any whitespace
> +problems in buffer; if it is 'never, it does not report problems.

                                ^^^^^^
should be                       `never'

> +problems in buffer; if it is 'never, it does not report problems.

                                ^^^^^^
should be                       `never'

>  * If `indent-tabs-mode' is non-nil:

> +   indentation               6. 8 or more SPACEs at beginning of line.
>  * If `indent-tabs-mode' is nil:

> +   indentation               6. TABS at beginning of line.

Why not

      indentation               6. if `indent-tabs-mode':

                                   8 or more SPACEs at beginning of line

                                   else: TABS at beginning of line.

OK.

 

> -     (when (if report-if-bogus has-bogus t)
> +     (when (if (equal report t) has-bogus (null report))

For better backward compatibility, this should check for `never' and
treat any other non-nil value as t.   IOW

        (when (pcase report-if-bogus (`nil t) (`never nil) (_ has-bogus))

Fine, revised patch to follow.

--
http://rrt.sc3d.org