bug#16683: 24.3; Crash on OS X when loading a bad PPM image

[Jan Djärv]

Hello.

9 feb 2014 kl. 23:30 skrev Marcus Karlsson <mk@acc.umu.se>:

> On Fri, Feb 07, 2014 at 01:53:14PM +0000, Gareth Rees wrote:
>> Emacs for Mac OS X crashes when trying to display a badly formatted
>> PPM image. The crash is 100% reproducible.
> 
> I'm able to reproduce this crash on the current head.
> 
> My impression after running it through the debugger is that -release is
> called on the pixmap after it has been deallocated earlier in pbm_load.
> I have created a patch that sets the pixmap to NO_PIXMAP in case
> pbm_load runs into an error.
> 

Applied thanks.

> In the long run the better solution is probably to look over the NS
> memory management so that it works properly.

This happens in the generic code, it should not try to free garbage, so this 
fix is OK.
An alternative would be to check load_failed in free_image.  Still generic code.

        Jan D.