bug#16800: 24.3; flyspell works slow on very short words at the end of big file

[Agustin Martin]

2014-02-22 22:03 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:

> Date: Sat, 22 Feb 2014 22:55:11 +0400

> From: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>

>
> > > Emacs words are language sensitive too.
> >
> > But not in the same way as ispell/flyspell is.  The CASECHARS,
> > NON-CASECHARS, and OTHERCHARS parameters of the dictionary are only
> > taken into account by ispell/flyspell.
>
> I think one could define a dictionary like: ("my" "[a]" "[^a]" "" ...)
> So the only letter for flyspell words is "a". That way "qqaaqqaaqq" is
> one word for emacs and two words with garbage around for flyspell. I
> think my solution fails in such case.

It's more complex than that: with some languages, and at least with
aspell, we take these parameters from the dictionary.  So they cannot
be known in advance in some cases.

Hi,

Not yet sure if  I am missing something important, but I am playing with a regexp search in flyspell-word-search-* functions based on what flyspell thinks is the word to spellcheck (`word') and what thinks should not be part of a word (`NOTCASECHARS'). Since no OTHERCHARS is used there may be some intermediate matches being false positives that will be discarded once flyspell-word checks them.

I have tested this in Alekseys's file and is apparently working well and in this particular case with much better efficiency. Need to think about more ad-hoc situations where it may fail or slow down things. Suggestions for possible failures are welcome.

Patch is attached. I did the tests against an old and patched version of flyspell.el (that shipped with Debian stable) and built the patch for it. Should apply and work similarly in trunk's flyspell.el.

--

Agustin

flyspell.el_flyspell-word-search.2.diff
Description: Text document