[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16434: bug#16694: bugs #16694/#16378: Patches
From: |
Barry OReilly |
Subject: |
bug#16434: bug#16694: bugs #16694/#16378: Patches |
Date: |
Wed, 2 Apr 2014 15:34:59 -0400 |
>> For my information, could you confirm the effect my patch has on
>> your theme problem?
> I'm sorry but you lost me there. Could you please elaborate more
> what it is you want me to comment on? Sorry... and thanks.
I wanted to know if the following happened to fix the problem
described at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16694#5 :
diff --git a/lisp/faces.el b/lisp/faces.el
index e008993..2f8560a 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -1615,7 +1615,8 @@ function for its other effects."
;; Initialize the face if it does not exist, then recalculate.
(make-empty-face face)
(dolist (frame (frame-list))
- (face-spec-recalc face frame)))
+ (face-spec-recalc face frame)
+ (make-face-x-resource-internal face frame)))
(defun face-spec-recalc (face frame)
"Reset the face attributes of FACE on FRAME according to its specs.
@@ -1641,8 +1642,7 @@ then the override spec."
(setq spec (face-spec-choose (face-default-spec face) frame))
(face-spec-set-2 face frame spec))
(setq spec (face-spec-choose (get face 'face-override-spec) frame))
- (face-spec-set-2 face frame spec))
- (make-face-x-resource-internal face frame))
+ (face-spec-set-2 face frame spec)))
(defun face-spec-set-2 (face frame spec)
"Set the face attributes of FACE on FRAME according to SPEC."
> The patch basically restores the behavior (wrt reverse video) to
> what Emacs 24.3 did without undoing any of the other work and fixes.
> I've tested everything as far as I could and all your test cases
> work just fine on my machine.
Confirmed, thanks. I have no further objections to the patch series.
Thank you for the work you put into it.
- bug#16434: bug#16694: bugs #16694/#16378: Patches, Barry OReilly, 2014/04/01
- bug#16434: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/01
- bug#16434: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/02
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Eli Zaretskii, 2014/04/05
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Stefan Monnier, 2014/04/05
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Eli Zaretskii, 2014/04/05
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/07
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/09
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/12
- bug#16378: bug#16694: bugs #16694/#16378: Patches, Eli Zaretskii, 2014/04/12
- bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/12
- bug#16434: bug#16694: bugs #16694/#16378: Patches, Eli Zaretskii, 2014/04/23
- bug#16434: bug#16694: bugs #16694/#16378: Patches, Matthias Dahl, 2014/04/23