bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme

[Glenn Morris]

Leo Liu wrote:

> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)

I don't think this is a bug.
The theme specifies attribute "nil" for this face (and some others).
As NEWS says:

  *** Face specs set via Custom themes now replace the `defface' spec
  rather than inheriting from it

So the theme gets what it asked for - every attribute unspecified.

If this was not what the theme author intended, perhaps the theme should
be changed.


(As an aside, what is the difference between "regression" and
"REGRESSION", and what is either supposed to actually mean in practice...)