bug#17783: 24.4.50; ERC: custom-set-variables with erc-modules after a (require 'erc) causes network names to be nil unless 'networks' modules is used

[Bradley M. Kuhn]

Put the following in FILE:

(require 'erc)
(custom-set-variables
 '(erc-modules (quote (button))))
(erc-select :server "irc.gnome.org" :port "6667" :nick "testignoreme1857" 
:full-name "Tester")

and call with emacs -Q -l FILE

As you connect to the IRC server, you'll see that the modeline -- initally
correct -- change the IRC network name "nil" after connecting.  If you
join a channel, that will be named #channel@nil, etc.

This problem does not occur if you switch the order of "(require 'erc)"
and the "(custom-set-variables)"

This problem also does not occur if you have "networks" in the
erc-modules list (since it changes the network name after connecting).

I discovered this problem because I still had a "(require 'erc)"
floating around in my .emacs, appearing before my "custom-set-variables" (from
years before when ERC wasn't part of Emacs).  This "(require 'erc)" isn't
actually needed, but it took a long time to determine what part of my
.emacs was causing the problem.


In GNU Emacs 24.4.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2014-06-14 on birch
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:     Debian GNU/Linux 7.5 (wheezy)

Configured using:
 `configure --prefix=/home/bkuhn/hacks/Installs/Emacs-from-git'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GSETTINGS NOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ERC

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-pcomplete-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o r t - e m <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Connecting to irc.gnome.org:6667... ...done
Logging in as 'testignoreme1857'...
Logging in without password
Logging in as 'testignoreme1857'... done

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils network-stream
starttls tls erc-list erc-menu easymenu erc-join erc-ring erc-networks
erc-track erc-match erc-button wid-edit cl-loaddefs cl-lib erc-fill
erc-stamp erc-netsplit erc-pcomplete pcomplete comint ansi-color ring
erc-goodies erc erc-backend erc-compat format-spec auth-source eieio
byte-opt bytecomp byte-compile cconv eieio-core gnus-util mm-util
help-fns mail-prsvr password-cache thingatpt pp time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 112482 13831)
 (symbols 48 22374 0)
 (miscs 40 43 166)
 (strings 32 23564 5390)
 (string-bytes 1 670223)
 (vectors 16 14036)
 (vector-slots 8 418903 7659)
 (floats 8 88 194)
 (intervals 56 317 432)
 (buffers 960 13)
 (heap 1024 24074 639))

-- 
   -- bkuhn