bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17854: The patch #3 of 3 for hideif.el, a lot of bug fixes and enhan


From: Glenn Morris
Subject: bug#17854: The patch #3 of 3 for hideif.el, a lot of bug fixes and enhancements
Date: Fri, 27 Jun 2014 23:22:29 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Glenn Morris wrote:

>> +(defcustom hide-ifdef-header-regexp
>> +  "^.*\\.[hH]\\([hH]\\|[xX][xX]\\|[pP][pP]\\)?"

This would be better written as

"\\.[hH]\\([hH]\\|[xX][xX]\\|[pP][pP]\\)?\\'"

(why not just case-fold?)

Also, you match it against buffer-name, which is fragile to things like
uniquify. Seems it would be better to match the file name.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]