bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16279: 24.3.50; [PATCH] eww: eww-history-mode fixup.


From: Ivan Shmakov
Subject: bug#16279: 24.3.50; [PATCH] eww: eww-history-mode fixup.
Date: Thu, 17 Jul 2014 07:06:57 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

>>>>> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:

 > Date: Sun, 29 Dec 2013 00:00:52 +0900

 > Since current eww-history does not work well, I fixed.  Please review
 > and install it to the official tree if appreciated.

 > Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

 > * net/eww.el (eww-list-histories,eww-history-browse): Fixup.
 > (eww-history-quit): Delete and use quit-window.
 > (eww-history-kill): Delete, because it doesn't work well and
 > not necessary.
 > (eww-history-mode-map): Delete some keys and add easy-menu.

[…]

        Except for the line numbers and such, this exact diff was
        applied as e8fcf8ca81c8 back in January.  Thus I guess this bug
        report may safely be closed.

        That being said, I’d disagree that eww-history-kill is not
        necessary: the eww-history records contain pages’ DOMs, sources,
        and rendered texts (as :dom, :source and :text properties,
        respectively), and the only currently “supported” way to clear
        that is to kill a specific EWW buffer and create one anew, which
        isn’t all that fine-grained, as it seems.

-- 
FSF associate member #7257      http://boycottsystemd.org/

Attachment: bin17U3OFqUV3.bin
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]