bug#19335: 24.4.51; ido.el: Include bookmark-files as virtual buffers

[Rasmus]

Hi,

The docstring of ido-add-virtual-buffers-to-list reads:

"Add recently visited files, and bookmark files, to the buffer list.
This is to make them appear as if they were \"virtual buffers\"."

But bookmarked files (C-x r l) are not in fact included (at least on my
system, and if they are it's not obvious how).  Perhaps I'm misreading the
docstring (since it says "bookmark files").  In any case, it would be nice
to include bookmarked files as virtual files (they are bookmarked and
therefore important).

I can add a defcustom to not include bookmarked files, if that's better.

Thanks,
Rasmus

-- 
And when I’m finished thinking, I have to die a lot

>From da38e2da2c13eee221e2530514df842fb471465c Mon Sep 17 00:00:00 2001
From: rasmus <rasmus@gmx.us>
Date: Wed, 10 Dec 2014 13:49:42 +0100
Subject: [PATCH] ido.el: Include bookmark-files as virtual buffers

* ido.el (ido-add-virtual-buffers-to-list): Include bookmarked files.

The docstring of ido-add-virtual-buffers-to-list suggests that
bookmarked files should include, but this does not in fact seem to
happen.
---
 lisp/ChangeLog | 4 ++++
 lisp/ido.el    | 8 +++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 454ee00..6b2c7f7 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2014-12-10  Rasmus Pank Roulund  <rasmus@pank.eu>
+
+       * ido.el (ido-add-virtual-buffers-to-list): Include bookmarked files.
+
 2014-12-10  Andreas Schwab  <schwab@suse.de>

        * files.el (file-tree-walk): Use file-name-as-directory
diff --git a/lisp/ido.el b/lisp/ido.el
index 5f7637c..f7c3f5f 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -3482,7 +3482,13 @@ This is to make them appear as if they were \"virtual 
buffers\"."
   (unless recentf-mode (recentf-mode 1))
   (setq ido-virtual-buffers nil)
   (let (name)
-    (dolist (head recentf-list)
+    (dolist (head (append recentf-list
+                          (and (boundp 'bookmark-alist)
+                               bookmark-alist
+                               (mapcar
+                                (lambda (bookmark)
+                                  (cdr-safe (assoc 'filename bookmark)))
+                                bookmark-alist))))
       (setq name (file-name-nondirectory head))
       ;; In case HEAD is a directory with trailing /.  See bug#14552.
       (when (equal name "")
--
2.1.3