bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion

[dylan]

Soemthing is wrong with dollar expansion on commands (${foo}).
It seems to break if eshell-buffer-shorthand on,
and also ${command} when command is a shell command seems to get lost...

M-x eshell RET
~ $ (setq eshell-buffer-shorthand t)
t
~ $ echo  ${uptime}
Symbol's value as variable is void: eshell-temp
~ $ echo  ${emacs-uptime}
Symbol's value as variable is void: eshell-temp
~ $ (setq eshell-buffer-shorthand nil)
nil
~ $ echo ${uptime}
# no output!
~ $ echo ${emacs-uptime}
4 minutes, 39 seconds



In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5)
 of 2014-12-15 on thor
Repository revision: 872617ad730906f9437b90c3b90af2e2458f00f6
Windowing system distributor `The X.Org Foundation', version 11.0.11602000
Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man
 --pdfdir=/usr/share/doc/emacs/pdf --with-sound=alsa --without-gconf
 --with-x-toolkit=gtk3 --with-xft 'CFLAGS=-march=x86-64 -mtune=generic
 -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4'
 CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LC_COLLATE: POSIX
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: EShell

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent messages:
Loading em-unix...done
History item: 17
History item: 16
History item: 15
History item: 14
History item: 13
History item: 12
delete-backward-char: Text is read-only
Sole completion
Partially completed

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message idna dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils em-unix em-term term disp-table
easymenu ehelp em-script em-prompt em-ls cl-loaddefs cl-lib em-hist
em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias pcomplete
comint ansi-color ring esh-var esh-io esh-cmd esh-opt esh-ext esh-proc
esh-arg esh-groups eshell esh-module esh-mode esh-util time-date tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcomment elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

Memory information:
((conses 16 95819 8904)
 (symbols 48 20003 0)
 (miscs 40 99 168)
 (strings 32 17152 4610)
 (string-bytes 1 527657)
 (vectors 16 12478)
 (vector-slots 8 417838 5964)
 (floats 8 77 97)
 (intervals 56 322 11)
 (buffers 976 14)
 (heap 1024 43589 956))