bug#19865: tar-untar-buffer: should honor default-directory

[Ivan Shmakov]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

[…]

 > The doc string of tar-untar-buffer says:

 >   "Extract all archive members in the tar-file into the current
 > directory."

 > which seems to match what it does.  Why isn't default-directory of
 > tar-data-buffer the right choice for doing that?

        Because the default-directory of the tar-mode buffer may be
        changed by the user (with M-x cd or otherwise) with the intent
        of directing tar-untar-buffer to extract the archive members
        into an arbitrary directory, per its docstring.

        Which fails, as the tar-data-buffer’s value for that same
        variable doesn’t get changed at that point.

        Another solution is to wrap with-current-buffer just around
        write-region, so that the rest of the code will still be
        evaluated with the tar-mode buffer being current.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A