[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-enco
From: |
Ivan Shmakov |
Subject: |
bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode |
Date: |
Fri, 20 Feb 2015 18:56:30 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> If string faces are rendered just the same as symbol ones,
> I think that's a misfeature.
I’m not familiar with the Emacs display code, so I have no
opinion on this.
>> I’d rather wonder if either facemenu-add-face should silently
>> ‘intern’ all the strings it gets before use, /or/ face-attribute
>> should do that. (Or perhaps both.)
> I think interning would be good, indeed, tho I would prefer if it
> emitted some kind of warning instead of doing it silently, to try and
> stop this bad habit.
Please consider the patch MIMEd.
--
FSF associate member #7257 np. Night Prowler — AC/DC … 3013 B6A0 230E 334A
--- a/lisp/facemenu.el
+++ b/lisp/facemenu.el
@@ -702,6 +702,9 @@ defun facemenu-add-face (face &optional start end)
text property. Otherwise, selecting the default face would not have any
effect. See `facemenu-remove-face-function'."
(interactive "*xFace: \nr")
+ (when (stringp face)
+ (warn "Face %S is a string; interning" face)
+ (setq face (intern face)))
(cond
((and (eq face 'default)
(not (eq facemenu-remove-face-function t)))
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -402,6 +402,9 @@ defun face-attribute (face attribute &optional frame
inherit)
value of `default' for INHERIT; this will resolve any unspecified or
relative values by merging with the `default' face (which is always
completely specified)."
+ (when (stringp face)
+ (message "Face %S is a string; interning" face)
+ (setq face (intern face)))
(let ((value (internal-get-lisp-face-attribute face attribute frame)))
(when (and inherit (face-attribute-relative-p attribute value))
;; VALUE is relative, so merge with inherited faces
- bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"', Jorge, 2015/02/19
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/19
- bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"', Eli Zaretskii, 2015/02/20
- bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"', Jorge, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Eli Zaretskii, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Stefan Monnier, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode,
Ivan Shmakov <=
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Stefan Monnier, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/20
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/21
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Eli Zaretskii, 2015/02/21
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/25
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Eli Zaretskii, 2015/02/25
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/25
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Eli Zaretskii, 2015/02/25
- bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode, Ivan Shmakov, 2015/02/25
- bug#19912: facemenu-add-face: does not handle 'face being set to a property list, Ivan Shmakov, 2015/02/21