bug#20322: 25.0.50; indent-tabs-mode should default to nil

[Dmitry Gutov]

On 04/15/2015 12:43 AM, Stefan Monnier wrote:

> This doesn't seem to talk about the same thing as what indent-tabs-mode does.
> I haven't looked at the code they use, but at least the example they
> give is:
>     function foo() {
>       return "bar";
>     }
>
> vs
>
>     function foo() {
>         // use tab for indentation
>         return "bar";
>     }
>
> whereas indent-tabs-mode does not influence which column is used, only
> which chars are used to get there.

The examples are admittedly bad (not sure why; maybe because the author 
found it non-trivial to insert a tab in the middle of a string literal, 
in their editor). Also see the Ruby one, where both sides of the 
comparison use 2-space offset.

However, the implementation seems to do the right thing:

https://github.com/outsideris/popularconvention/blob/master/src/parser/js-parser.coffee#L99-L100
https://github.com/outsideris/popularconvention/blob/master/src/parser/java-parser.coffee#L51-L52
https://github.com/outsideris/popularconvention/blob/master/src/parser/php-parser.coffee#L59-L60

Anyway, the results seem to coincide with what's I've seen in practice.

If they can actually change someone's position, we can double-check 
them, run the analysis ourselves, look for other statistics, etc.