bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20925: 25.0.50; isearch-exit calls isearch-done twice


From: Juri Linkov
Subject: bug#20925: 25.0.50; isearch-exit calls isearch-done twice
Date: Tue, 30 Jun 2015 01:07:08 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu)

> `isearch-exit' calls `isearch-done' by way of `isearch-edit-string'
> and `with-isearch-suspended', and then calls it again.
> I don't know why it does so but this change gets rid of the error:
>
> --- isearch.el~       2015-06-28 22:04:38.000000000 +0000
> +++ isearch.el        2015-06-29 09:26:19.216444200 +0000
> @@ -1184,8 +1184,8 @@
>    (if (and search-nonincremental-instead
>          (= 0 (length isearch-string)))
>        (let ((isearch-nonincremental t))
> -     (isearch-edit-string)))
> -  (isearch-done)
> +     (isearch-edit-string))
> +    (isearch-done))
>    (isearch-clean-overlays))

Thanks, I believe this is the right fix to avoid calling
‘isearch-done’ twice.  Could you please add a short 1-line comment
explaining that ‘isearch-edit-string’ already calls ‘isearch-done’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]