bug#21007: 25.0.50; Around advice doesn't seem to work

[Nicolas Richard]

Mark Karpov <markkarpov@openmailbox.org> writes:
> Reproducible with ‘emacs -Q’:
>
> (defun mk-anti-ido-advice (func &rest args)
>   "Temporarily disable IDO and call function FUNC with arguments ARGS."
>   (message "Called!")) ;; just for testing
>
> (defun mk-disable-ido (command)
>   "Disable IDO when command COMMAND is called."
>   (advice-add command :around #'mk-anti-ido-advice))
>
> (mk-disable-ido 'dired-create-directory)
>
> Now, in description of ‘dired-create-directory’ one can see that
> ‘:around’ advice is registered. However, when I call
> ‘dired-create-directory’ either via ‘+’ keybinding or via ‘M-x
> dired-create-directory’, old version of the function is called. I don't
> see "Called!" message in the minibuffer. Is it bug or feature?

I see a prompt for a directory, but when I hit RET to confirm, I get a
"Called!" message.

If that's what you see also and you don't want to see the prompt, simply
make mk-anti-ido-advice an (interactive) function (the new interactive
spec will replace the old one).

Nico.