bug#21496: 25.0.50; guile-file compilation-error regexp is too wide

[Jostein Kjønigsen]

Attached is a new patch which ensures guile-file only triggers when the
match has an actual extension.

That's honestly all that's needed to fix my issue and it should
(hopefully) be permissive enough to work with whatever extension
Schemers prefer.

Everyone happy now? :)

--
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net


On Sun, Sep 20, 2015, at 10:08 AM, Jostein Kjønigsen wrote:
> Good feedack Andreas!
> 
> While there probably isn't any requirement for emacs-lisp to have the
> extension "el", there's always some kind of conventions which goes
> around.
> 
> I assume the same applies to Scheme. What extensions are
> conventionally used for Scheme?
> 
> Checking wikipedia[1] I see the extensions "scm" and "ss" is used.
> Another search yields[2] "s" and "scheme" too.
> 
> Can any Scheme-programmer elaborate on which extensions would be
> useful to include in a patch like this?
> 
> I don't think there's any debate about the current regexp being too
> wide, so it needs to be narrowed down somehow.
> 
> [1] https://en.wikipedia.org/wiki/Scheme_%28programming_language%29
> [2] https://duckduckgo.com/?q=scheme+lang+file-extension
> 
> --
> Jostein Kjønigsen
> jostein@kjonigsen.net / jostein@secure.kjonigsen.net
> 
> 
> On Sun, Sep 20, 2015, at 09:59 AM, Andreas Schwab wrote:
>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>> 
>>> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
>>> index f9c097e..27a3833 100644
>>> --- a/lisp/progmodes/compile.el
>>> +++ b/lisp/progmodes/compile.el
>>> @@ -477,7 +477,9 @@ File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = 
>>> \\([0-9]+\\)\\)?"
>>>     ;;
>>>     "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
>>>     1 2 3)
>>> -    (guile-file "^In \\(.+\\):\n" 1)
>>> +
>>> +    ;; file-entries does not have to be errors, treat as info.
>>> +    (guile-file "^In \\(.+\\.scm\\):\n" 1 nil nil 0)
>> 
>> There is no requirement that names of scheme files end in `.scm'.
>> 
>> Andreas.
>> 
>> --
>> Andreas Schwab, schwab@linux-m68k.org
>> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
>> "And now for something completely different."

Emacs-compilation-mode-fixes.patch
Description: Text Data