>>> Eli Zaretskii
> No, there was no decision yet to start the feature freeze.
In that case, here is my feedback on a quick review.
>>> Jay Belanger
> With the patch, if the yanked number already has the radix prefix, there
> is an error. It might make more sense to have Calc do an appropriate
> conversion.
I did not try that case as I meant to use the prefix only when the copied number does not have a calc-style prefix. But that's a valid point. If the copied number has calc-style prefix, what should have a higher priority?
- The radix translated by the copied number with prefix, or
- The radix conveyed by the user specified prefix to calc-yank?
I believe that if the user has intentionally used the prefix, the calc-yank prefix should override. Either way, it will be easy with some string manipulation.
> Also, the number of radixes in the patch is less than Calc allows.
I assumed the use cases of only the common radixes used in programming. How about I display a prompt for the user to enter any radix they like (I believe calc supports up to radix 36) if the prefix is specifically '(4) ( a list prefix created when user uses C-u specifically for prefix).
So now, C-2 C-y will prefix the yanked number with "2#". But C-u C-y will show a prompt where the user will enter radix. If the user entered 9, the prefix appended will be "9#". Does this option sound fair?
> It might make more sense to have calc-yank use the current Calc's current radix rather than a prefix radix.
I need some clarification for this point. Did you mean that if the user has set the calc radix to hex by using "d6" and now if they yank a number "1000" it gets yanked automatically as "16#1000". If yes, I believe it will cause a huge disturbance in the way people might have already got used to yanking in calc.
> I don't recall the policy on using cl- functions, but cond could easily be used instead of cl-case.
I personally find cl-case syntax very concise and so I used that. In a thread in emacs-devel, there is/was a discussion on if cl-lib should be preloaded automatically. I believe that until that decision is reached, I should use cond instead of cl-case.