bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21707: include-file cleanup for src directory


From: Paul Eggert
Subject: bug#21707: include-file cleanup for src directory
Date: Tue, 20 Oct 2015 11:50:34 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Eli Zaretskii wrote:
Would it help if we avoid including any of our headers in any
other of our headers, so that the headers included by a particular C
file are visible by just looking at that single C file?

That would run afoul of a more important design goal, which is that we should be able to include headers in any order. And anyway, compiling a typical C file ordinarily brings in oodles of system headers that the C file doesn't explicitly ask for, so regardless of our style the only practical way to see what headers a C file includes is to compile it and see what gcc -E outputs.

Ideally a C source file should include all headers that define symbols the source file directly uses, and no headers other than that. This should be true for both .h and .c files. We're not there by a long shot, but that should be the goal.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]