bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21799: Requesting review for change to js.el


From: Dmitry Gutov
Subject: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 14:36:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0

On 10/31/2015 11:37 AM, Jackson Hamilton wrote:
See attached patch. Adds JSX indentation support to js-mode.

Hi Jackson,

JSX files have a different extension, right? Why don't we make it a separate major mode?

It can also live in js.el and derive from js-mode. The only thing it'll change (for now?) is the indentation function.

And for those who also want the js2-mode AST, we can either tell them to use js2-minor-mode, or also create a js2-jsx-mode that would derive from js2-mode and use the indentation function defined here.

Then there will be no need for the option js-indent-jsx.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]