bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#22737: 25.1; Finalizer should be optional in dynamic modules


From: Jess Balint
Subject: bug#22737: 25.1; Finalizer should be optional in dynamic modules
Date: Thu, 18 Feb 2016 15:52:55 -0600
User-agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu)

Dynamic modules are really cool so far, but I think finalizers should
not be mandatory for user pointers (alloc.c):

#ifdef HAVE_MODULES
              else if (mblk->markers[i].m.u_any.type == Lisp_Misc_User_Ptr)
                {
                  struct Lisp_User_Ptr *uptr = &mblk->markers[i].m.u_user_ptr;
                  uptr->finalizer (uptr->p); <----- should NULL-check first
                }
#endif

c.f. https://github.com/emacs-mirror/emacs/blob/master/src/alloc.c#L6893

Thanks!

Jess





reply via email to

[Prev in Thread] Current Thread [Next in Thread]