bug#19977: 24.4; Incorrect translation of Super modifier with Ctrl or Meta on OS X

[Adrian Robert]

On 2016.3.29, at 19:57, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Philipp Stephani <p.stephani2@gmail.com>
>> Date: Tue, 29 Mar 2016 16:38:52 +0000
>> Cc: 19977@debbugs.gnu.org
>> 
>> If I comment out the if block below the comment
>> 
>> /* if super (default), take input manager's word so things like
>> dvorak / qwerty layout work */
>> 
>> in nsterm.m, everything works. Unless somebody can explain why that if block 
>> exists at all (i.e. why
>> [theEvent characters] instead of [theEvent charactersIgnoringModifiers] is 
>> used), then I'd suggest to
>> remove the block completely. 
>> 
>> Attached a patch to remove this code. 
> 
> Adrian, any comments?  It's your code from 7 years ago.


Heh, well of the top of my head… ;-)

Did you try testing Dvorak / Qwerty layout?  If not, that’s under System 
Preferences, Keyboard, add new, English, select Dvorak or Dvorak / Qwerty.

From what I remember, the issue had to do with cmd-key shortcuts when one of 
those layouts was in use.  I think users were expecting the letter reported for 
the cmd shortcut to either agree with or disagree with the dvorak layout.  
Using [theEvent characters] caused it to use what they were expecting.

It sounds like either this wasn’t the right solution, or user expectations 
vary.  In either case I would agree with simplifying the code and removing the 
part you suggest.


-Adrian