bug#23179: 25.0.92; Restore `M-,' to continue etags search

[Dmitry Gutov]

On 04/04/2016 11:43 AM, Anders Lindgren wrote:

> Unfortunately, I have very little time to do heavy lifting on Emacs
> anymore (which is why recently stepped down maintaining the NS port).
> However, I try to help out by providing user experience feedback,
> whenever I find something that doesn't feel right.

As far as user feedback goes, I need more than "the new key bindings are 
different from the old ones". In-depth discussion of new generic 
commands and their semantics would be welcome.

If nobody steps up to implement your incremental search UI soon, though, 
we'll most likely release Emacs 25.1 with the current xref UI.

>     Not updated when? When you call `next-error'? I imagine that's
>     something to implement in that facility, then, so that every other
>     mode implementing next-error-function benefits.
>
>
> Yes. In a *grep* buffer, the point and arrow moves to reflect the
> current entry.

OK. That's already been brought up in one of the bugs I've referenced.

> It could be easily fixed by a call to `font-lock-ensure' (at least for
> files already loaded into Emacs).

Please test the attached patch. I'd like to know if there are cases when 
the highlighting overhead is noticeable.

However, this approach precludes an optimization I've been considering: 
when a given regexp doesn't use any Emacs-specific syntax, there's no 
need to visit the file. We would simply construct the match based on 
Grep's output. It would speed up the process a lot, in certain cases.

>     http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489
>     http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20493
>
>     Help welcome.
>
>
> OK, I see that those problems are known. I hope that they get fixed, as
> they are annoying.

Indeed. But so far there's no consensus on how to go about fixing them.

>     On the other hand, yes, the fact that the matches don't appear as
>     soon as they're available, is a problem. Could you open a separate
>     bug for that?
>
>
> I'd rather prefer if you would file a bug, I don't know which part I
> should refer to, as I've only used your experimental `tags-find-regexp'
> code.

You've never used e.g. xref-find-references?

Bug#23212 filed.

font-lock-ensure-in-xref--collect-matches.diff
Description: Text Data