bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB


From: Lars Ingebrigtsen
Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
Date: Thu, 28 Apr 2016 19:26:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Drew Adams <drew.adams@oracle.com> writes:

>> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
>> >> >          word))))
>> >> >           (setq key (list (intern word))))
>> >> >          ((or (equal word "REM") (string-match "^;;" word))
>> >> > --- 708,714 ----
>> >> >         (substring word (match-beginning 3)
>> >> >             (match-end 3))))
>> >> >           (not (string-match
>> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
>> >>
>> >> There's probably a missing | in the patch...
>> >
>> > Yes, good catch.  Should be \\|TAB, not \\TAB.
>> 
>> Can you submit a new patch, preferably tested?
>
> Sorry; I really don't have the time now.  But I think that all
> of the relevant info has been provided, so you should be able
> to DTRT.  The patch is quite tiny.  And it is unlikely that
> the `edmacro-parse-keys' has changed much, if at all, since
> 2014.  Just change \\TAB to \\|TAB in the patch.

The patch you sent obviously hadn't been tested, because it was
syntactically wrong.  I'm not going to apply patches that haven't been
tested.

Please create a new patch and post it here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]