[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15047: 24.3.50; doc string of `find-listp-find-files' etc.
From: |
Lars Ingebrigtsen |
Subject: |
bug#15047: 24.3.50; doc string of `find-listp-find-files' etc. |
Date: |
Fri, 29 Apr 2016 15:36:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Drew Adams <drew.adams@oracle.com> writes:
> The doc should distinguish between the files _within_ a directory, i.e.,
> descending into its subdirectories recursively, and the files in a
> directory, i.e., not including in descendent directories.
>
> Pick any terminology you like, but please make it clear.
>
> 1. `find-listp-find-files': The doc of does not at all indicate that it
> in fact searches also subdirectories, recursively.
Fixed...
> 2. `find-lisp-find-files-internal': The doc says that
> "DIRECTORY-PREDICATE is used to decide...", but it does not say how,
> which is central to the meaning of DIRECTORY-PREDICATE. Just say that
> if DIRECTORY-PREDICATE returns non-nil then descend into subdirs etc.
It's a predicate. That's what predicates do.
> 3. `find-lisp-find-dired-internal': The doc says "Run find...".
> Please change this to "Run `find'...".
But it doesn't run the command `find'. And it says:
"Run find (Lisp version) and go into Dired mode on a buffer of the output."
> 4. `find-lisp-find-dired-filter': Please replace the doc string with
> something correct or useful. The command does not "change the
> filter..." or anything of the kind. And please wrap function names with
> `...' in doc.
But it does change the filter...
;;;###autoload
(defun find-lisp-find-dired-filter (regexp)
"Change the filter on a `find-lisp-find-dired' buffer to REGEXP."
(interactive "sSet filter to regexp: ")
(setq find-lisp-regexp regexp)
(revert-buffer))
And I see that Juanma has already fixed the quoting...
> 5. `find-lisp-format': Add a doc string. You "lifted" this from
> ls-lisp.el, but you neglected to lift the doc string along with it.
Done.
> 6. `find-lisp-time-index', `find-lisp-format-time': Replace the code
> comments with doc strings. This is the 21st century; we can afford
> the extra cost. ;-)
Done.
> 7. `find-lisp-find-dired-insert-file': Add a doc string.
Seems unnecessary.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#15047: 24.3.50; doc string of `find-listp-find-files' etc.,
Lars Ingebrigtsen <=