bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list'

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> I took only a cursory look at the code, after finding out that eldoc's
> idle timer was still getting called after I had turned off `eldoc-mode'.
> I discovered this because I had `debug-on-entry' for `split-string'.
>
> Seems like turning off `eldoc-mode' should not only remove
> `eldoc-schedule-timer' from `post-command-hook' but should also turn off
> that timer, so it does not keep turning eldoc back on.  It seems that
> nothing ever removes `eldoc-timer' from `timer-idle-list' or deletes the
> timer.

I've now made switching eldoc mode off cancel the timer.

If eldoc mode is running in other buffers, the post-command-hook will
ensure that it's started again whenever you do something, so I think
that should be ok...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no