bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails

[Ken Brown]

On 5/15/2016 12:15 PM, Eli Zaretskii wrote:
> > From: Ken Brown <kbrown@cornell.edu>
> > The error is generated by
> > Ffind_operation_coding_system when it is called by
> >
> > CALLN (Ffind_operation_coding_system,
> >         Qopen_network_stream, name, p->buffer,
> >         host, service)
> >
> > in set_network_socket_coding_system.
>
> Ffind_operation_coding_system includes an explicit test for the 4th
> argument to be an integer:
>
>   if (!(STRINGP (target)
>         || (EQ (operation, Qinsert_file_contents) && CONSP (target)
>             && STRINGP (XCAR (target)) && BUFFERP (XCDR (target)))
>         || (EQ (operation, Qopen_network_stream) && INTEGERP (target))))
>             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     error ("Invalid argument %"pI"d of operation `%s'",
>            XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation)));
>
> This should obviously be augmented, now that the value can also be t.

Presumably the documentation of open-network-stream should also be 
updated to reflect this.  I hesitate to do this myself without knowing 
for sure that t is an acceptable value for all calls to 
open-network-stream.  I'd rather leave it for someone more familiar with 
the code, like Lars.

Ken