[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23785: Emacs 25: 'Undo' overdoes things.
From: |
Stefan Monnier |
Subject: |
bug#23785: Emacs 25: 'Undo' overdoes things. |
Date: |
Tue, 21 Jun 2016 17:25:29 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
> + /*
> + Temporarily enable the undo-buffer to ensure that the change
> + is marked as an undoable one. Bug #23785.
> + */
> + bset_undo_list(current_buffer,Qnil);
Additionally to Eli's remark about the shape of your comments, please
also put spaces before open parens and after commas.
> insert_from_buffer (XBUFFER (conversion_buffer),
> same_at_start_charpos, inserted_chars, 0);
> + bset_undo_list(current_buffer,Qt);
Instead of two bset_undo_list, you could use a single specbind since the
above code is almost immediately followed by unbind_to.
But more seriously, I'm wondering: where is undo-list set to t (and
hence causing the problem we're seeing)?
Searching for "undo" in that function gives m the impression that
undo-0list won't be set to t during the call to insert_from_buffer.
What am I missing?
Stefan
- bug#23785: Emacs 25: "Undo" overdoes things., (continued)
- bug#23785: Emacs 25: "Undo" overdoes things., Stefan Monnier, 2016/06/18
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/19
- bug#23785: Emacs 25: 'Undo' overdoes things., Stefan Monnier, 2016/06/19
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Stefan Monnier, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things.,
Stefan Monnier <=
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/17
- bug#23785: Emacs 25: "Undo" overdoes things., Alan Mackenzie, 2016/06/18
- bug#23785: Emacs 25: "Undo" overdoes things., Óscar Fuentes, 2016/06/17
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/20