bug#24035: 25.1.50; Eww breaks on images?

[Clément Pit--Claudel]

On 2016-07-20 11:35, Kaushal Modi wrote:
> OK, cool!
> 
> How did you figure that out? Also how did shr get incorrectly compiled? 

shr calls setf on (image-property). That will only work if there's a setter 
defined for image-property; otherwise, the setf macro will be expanded 
incorrectly at compile time. That setter is only available if image has been 
loaded.

> So then, this commit ( 
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90fb0b2d13d0f44ecb9606587681cb4d8a6f0225
>  ) should not be needed.

I think this is the right fix. shr does require image to be loaded for the setf 
to compile properly. Thus the dependency explicit is the right thing to do (I 
think).

Cheers,
Clément.

signature.asc
Description: OpenPGP digital signature