bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric pref


From: Stephen Berman
Subject: bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f'
Date: Fri, 22 Jul 2016 09:25:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

On Fri, 22 Jul 2016 10:14:39 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

> unblock 19759 by 23999
> thanks
>
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Cc: eliz@gnu.org, jwiegley@gmail.com, monnier@iro.umontreal.ca
>> Date: Fri, 22 Jul 2016 09:01:12 +0200
>> 
>> Ping!  (This was made a blocking bug for 25.1.)
>
> I'd appreciate if people who think some bug needs to block the release
> asked for my and John's agreement first.

Just to be clear, I didn't make it a blocker.

> In this case, I don't agree that this should block the release, since
> a very simple workaround is available.
>
>> > diff --git a/lisp/rect.el b/lisp/rect.el
>> > index 43621d9..9dd5db4 100644
>> > --- a/lisp/rect.el
>> > +++ b/lisp/rect.el
>> > @@ -644,7 +644,7 @@ rectangle--*-char
>> >                 (curcol (current-column))
>> >                 (nextcol
>> >                  (condition-case nil
>> > -                    (save-excursion
>> > +                    (progn
>> >                        (funcall cmd 1)
>> >                        (cond
>> >                         ((> bol (point)) (- curcol 1))
>
> I'm fine with pushing to master if no one objects to this particular
> solution.

Why not emacs-25, given that the behavior is a regression from 24.5 (and
of course assuming the fix doesn't break anything else)?

Steve Berman





reply via email to

[Prev in Thread] Current Thread [Next in Thread]