On Sat, Jul 23, 2016 at 3:34 AM Eli Zaretskii <
eliz@gnu.org> wrote:
I see no reason to assume that file names cannot appear in comments.
I have already tested with these use cases and now it seems to do-the-right-thing:
In the below table, 'x' represents the point (the cursor would be on the character to its right).
The second column shows the value that ffap-string-at-point is set to on doing C-x C-f (with the ido setup explained in the first email).
|-----------------------------------+---------------------------------|
| Example string in `c-mode' buffer | Returned `ffap-string-at-point' |
|-----------------------------------+---------------------------------|
| x//tmp | "tmp" |
| //xtmp | "tmp" |
| x////tmp | "tmp" |
| ////xtmp | "tmp" |
| x// //tmp | "" |
| // //xtmp | "//tmp" |
|-----------------------------------+---------------------------------|
To try this out, paste the below in a new buffer and M-x c-mode.
//tmp
Now do C-x C-f with cursor at those 6 different points and you will see that an attempt to read /tmp happens only in the case of "// //tmp" when the point is anywhere in the "//tmp" portion following "// ".
I could agree with a user option to disable this behavior, but
disabling it unconditionally is IMO a mistake.
Of course, if this patch returns in unintended ffap-string-at-point, I will add a defcustom to enable this behavior.