[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24166: With --eval, errors in string-match-p do not produce backtrac
From: |
Eli Zaretskii |
Subject: |
bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!) |
Date: |
Sun, 07 Aug 2016 17:12:18 +0300 |
> From: npostavs@users.sourceforge.net
> Cc: 24166@debbugs.gnu.org, clement.pitclaudel@live.com
> Date: Sat, 06 Aug 2016 08:25:17 -0400
>
> Here's the new patch.
Thanks. I have one minor comment below.
> Is it correct to put the DEFSYM next to the DEFVAR_LISP?
It isn't incorrect, and even eval.c already does that.
> + /* If we are debugging an error within a call to `string-match-p',
> + then make sure debugger code can still use match data. */
Please mention in the comment that string-match-p binds
inhibit-changing-match-data, and that it is only one example of that.
Otherwise, LGTM, thanks.
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Clément Pit--Claudel, 2016/08/05
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), npostavs, 2016/08/05
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Clément Pit--Claudel, 2016/08/05
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Eli Zaretskii, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Noam Postavsky, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Eli Zaretskii, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Noam Postavsky, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Eli Zaretskii, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), npostavs, 2016/08/06
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!),
Eli Zaretskii <=
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), npostavs, 2016/08/07
- bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!), Clément Pit--Claudel, 2016/08/07
- Message not available
- Message not available
- bug#23949: acknowledged by developer (Re: bug#24166: With --eval, errors in string-match-p do not produce backtraces (but errors in string-match do?!)), Kaushal Modi, 2016/08/09