[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request
From: |
Eli Zaretskii |
Subject: |
bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request |
Date: |
Thu, 11 Aug 2016 17:47:37 +0300 |
> Cc: stakemorii@gmail.com, larsi@gnus.org, schwab@linux-m68k.org,
> 24117@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 11 Aug 2016 05:52:42 +0300
>
> >> On the master branch, host is passed through IDNA encoding, but
> >> real-fname is untouched. On emacs-25, I think we should convert both
> >> to unibyte.
> >
> > Not sure I understand why there should be a difference between the two
> > branches. Encoding an ASCII string doesn't do any harm.
>
> Since it's ASCII, using utf-8 there seems misleading to me. It's a
> question of readability.
But AFAIU it doesn't have to be ASCII, it could include non-ASCII
characters, no?
> As a bonus, using us-ascii will validate that the strings indeed do
> not contain any unexpected characters.
If we did allow non-ASCII characters until now, we will definitely
hear from someone who'd say this is a regression.
> Thanks. Attaching a patch, it seems to work well enough.
LGTM, modulo the considerations about the encoding.
Thanks.
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, (continued)
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/09
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Dmitry Gutov, 2016/08/10
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/10
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Dmitry Gutov, 2016/08/10
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Ted Zlatanov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Dmitry Gutov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Ted Zlatanov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Lars Ingebrigtsen, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Ted Zlatanov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Lars Ingebrigtsen, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request,
Eli Zaretskii <=
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Dmitry Gutov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Dmitry Gutov, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/11
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, John Wiegley, 2016/08/12
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Sho Takemori, 2016/08/12
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/13
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Sho Takemori, 2016/08/13
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Eli Zaretskii, 2016/08/13
- bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request, Sho Takemori, 2016/08/13