[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .j
From: |
Tino Calancha |
Subject: |
bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix |
Date: |
Sat, 27 Aug 2016 17:04:01 +0900 (JST) |
User-agent: |
Alpine 2.20 (DEB 67 2015-01-07) |
emacs -Q:
;; file: full name of a .jpeg file in your filesystem
(let ((file "/tmp/bug24317.jpeg"))
(require 'dired)
(require 'image-dired)
(dired file)
(image-dired-display-thumbs)
(image-dired-rotate-original 90))
;; if: Only JPEG images can be rotated!
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 4ea0333150937d3f2f615df1ed476e6279caf77b Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Sat, 27 Aug 2016 16:53:37 +0900
Subject: [PATCH] image-dired-rotate-original: regexp doesn't match .jpeg
suffix
* lisp/image-dired.el (image-dired-jpeg-suffix-regexp): New defvar.
(image-dired-rotate-original, image-dired-get-exif-file-name):
Use it (Bug#24317).
---
lisp/image-dired.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 67b023d..bb43a55 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1906,13 +1906,16 @@ image-dired-refresh-thumb
(clear-image-cache)
(image-dired-create-thumb file (image-dired-thumb-name file))))
+(defvar image-dired-jpeg-suffix-regexp "\\.[Jj][Pp][Ee]?[Gg]$"
+ "Regexp to match JPEG file extensions.")
+
(defun image-dired-rotate-original (degrees)
"Rotate original image DEGREES degrees."
(if (not (image-dired-image-at-point-p))
(message "No image at point")
(let ((file (image-dired-original-file-name))
command)
- (if (not (string-match "\\.[jJ][pP[eE]?[gG]$" file))
+ (if (not (string-match image-dired-jpeg-suffix-regexp file))
(error "Only JPEG images can be rotated!"))
(setq command (format-spec
image-dired-cmd-rotate-original-options
@@ -1952,7 +1955,8 @@ image-dired-get-exif-file-name
YYYY_MM_DD_HH_MM_DD_ORIG_FILE_NAME.jpg. Used from
`image-dired-copy-with-exif-file-name'."
(let (data no-exif-data-found)
- (if (not (string-match "\\.[Jj][Pp][Ee]?[Gg]$" (expand-file-name
file)))
+ (if (not (string-match image-dired-jpeg-suffix-regexp
+ (expand-file-name file)))
(progn
(setq no-exif-data-found t)
(setq data
--
2.9.3
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.20.9)
of 2016-08-26 built on calancha-pc
Repository revision: 1c7166a3ba399efbefc65feb8a6a41ef0dfa33a4
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix,
Tino Calancha <=
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Thien-Thi Nguyen, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/28