[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .j
From: |
Eli Zaretskii |
Subject: |
bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix |
Date: |
Sat, 27 Aug 2016 15:55:22 +0300 |
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 27 Aug 2016 21:18:37 +0900 (JST)
> cc: Thien-Thi Nguyen <ttn@gnu.org>, tino.calancha@gmail.com,
> 24317@debbugs.gnu.org
>
> > That is better, yes. Except that
> >
> > (let ((case-fold-search)) (image-type-from-file-name "foo.JPEG"))
> > => nil
> >
> > So I guess that function needs a minor change to be more robust.
> That's right. It wuld be worth take a look on
> 'image-type-from-file-name'.
>
> I have corrected previous patch. I drop expand-file-name from
> 'image-dired-jpeg-file-p'. I also corrected the extra paren mentioned
> before.
> If people is happy with it i will apply this patch.
I think we should indeed use image-type instead of having yet another
function that recognizes JPEG. The problem I pointed out should be
fixed in image-type-from-file-name, regardless.
Sorry this wasn't clear enough from what I wrote before.
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Thien-Thi Nguyen, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/27
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix,
Eli Zaretskii <=
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/28
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Eli Zaretskii, 2016/08/28
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Tino Calancha, 2016/08/28
- bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix, Andreas Schwab, 2016/08/28