bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24555: [PATCH] Remove unused variable `command-debug-status'


From: Eli Zaretskii
Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 17:58:41 +0300

> From: Philippe Vaucher <philippe.vaucher@gmail.com>
> Date: Wed, 28 Sep 2016 14:39:02 +0200
> 
> For information, I did the procedure for copyright assignment to Emacs and it 
> is complete.

Indeed, your assignment is on file.

> This patch removes the variable `command-debug-status', which really seems to 
> be unused since a long time
> to me (that's what "git -G Vcommand-debug-status" says).

Thanks for bringing this up.

I looked into the history of this variable, and found that it was
still supported in Emacs 24.5, and was removed during development of
Emacs 25 by this commit:

  commit 0e4857b7d84f958f66e726ed57b824427b272681
  Author: Stefan Monnier <monnier@iro.umontreal.ca>
  Date:   Tue May 27 20:09:14 2014 -0400

      * src/callint.c (Ffuncall_interactively): New function.
      (Qfuncall_interactively): New var.
      (Qcall_interactively): Remove.
      (Fcall_interactively): Use it.
      (syms_of_callint): Defsubr it.
      * lisp/subr.el (internal--funcall-interactively): New.
      (internal--call-interactively): Remove.
      (called-interactively-p): Detect funcall-interactively instead of
      call-interactively.
      * lisp/simple.el (repeat-complex-command): Use funcall-interactively.
      (repeat-complex-command--called-interactively-skip): Remove.

As you see, the commit log doesn't mention the removal of the
variable.  Stefan, was it removed on purpose?  If so, can you tell
why?

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]