bug#24580: 25.2.50; query-replace history doesn't work

[Mark Oteiza]

On 01/10/16 at 11:40am, Eli Zaretskii wrote:
> > From: Marcin Borkowski <mbork@mbork.pl>
> > Date: Sat, 01 Oct 2016 08:43:27 +0200
> > 
> > - start emacs -Q
> > - press `a' `C-b', `M-%', `a', `RET', `b', `RET', `!'
> > - press `M-%', `M-p'
> > 
> > Emacs says "Beginning of history; no preceding item".
> 
> Mark, this regression was caused by the lexical-binding change in
> replace.el.  Could you please take a look?

The problem lies (at least) in query-replace-read-from, where
query-replace-from-to is let bound, and later read-from-minibuffer
refers to the symbol 'query-replace-from-to.  At first sight, it looks
like it could be fixed by putting some of the setup done by these
bindings into the minibuffer setup hook.

As for the other problem Marcin mentioned, that seems to be due to the
custom-reevaluate-setting call in the same function.