bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24606: 25.1.50; (thing-at-point 'filename) doesn't recognize names w


From: Eli Zaretskii
Subject: bug#24606: 25.1.50; (thing-at-point 'filename) doesn't recognize names with @
Date: Tue, 04 Oct 2016 11:02:46 +0300

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Tue, 4 Oct 2016 16:18:48 +0900 (JST)
> Cc: tino.calancha@gmail.com
> 
> >From 3a4a8c7245a4b4713a92cd77e75a375cf366a825 Mon Sep 17 00:00:00 2001
> From: Emanuel Berg <embe8573@student.uu.se>
> Date: Tue, 4 Oct 2016 16:10:44 +0900
> Subject: [PATCH] thing-at-point: Add @ as a valid character for file names
> 
> Reported in:
> https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01219.html
> * lisp/thingatpt.el (thing-at-point-file-name-chars): Add @ (Bug#24606).
> ---
>   lisp/thingatpt.el | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
> index 9920fa0..704dc69 100644
> --- a/lisp/thingatpt.el
> +++ b/lisp/thingatpt.el
> @@ -244,7 +244,7 @@ thing-at-point-bounds-of-list-at-point
> 
>   ;;  Filenames
> 
> -(defvar thing-at-point-file-name-chars "-~/[:alnum:]_.${}#%,:"
> +(defvar thing-at-point-file-name-chars "-@~/[:alnum:]_.${}#%,:"
>     "Characters allowable in filenames.")

On a typical Posix system, a file name can include any character
except '/' and a null character.  So I'm not sure we should add every
character that some user somewhere needs.

How many others here need this character be in a file name, for
thing-at-point purposes?  Maybe we should ask on emacs-devel before
deciding.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]