bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24985: Add missing provide statements


From: Philippe Vaucher
Subject: bug#24985: Add missing provide statements
Date: Tue, 22 Nov 2016 11:42:18 +0100

Hello,

While correcting misuse of `eval-after-load' in some libraries, we discovered that `text-mode' does not `provide' itself as a feature.

That forces people to use `eval-after-load' with a string (filename), instead of a symbol (feature), which is the better form. It is the better form because with a string, any file named the same way triggers the eval-after-load which is problematic for custom configurations named after
packages.

Original thread at https://github.com/magnars/expand-region.el/pull/212

I used the following command to figure out which other files might need additional `provide' statements:

grep -rL '(provide' ~/work/emacs/lisp | xargs egrep 'define-[^ ]+-mode' | grep -v ChangeLog

Thanks,
Philippe

Attachment: 0001-Add-missing-provide-statements.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]