[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing e
From: |
npostavs |
Subject: |
bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore |
Date: |
Thu, 22 Dec 2016 19:03:53 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Reuben Thomas <rrt@sc3d.org> writes:
> On Dec 22, 2016 2:17 AM, <npostavs@users.sourceforge.net> wrote:
>> >
>> > The only thing I'd change in your match is, as in mine, remove the FIXME
>> > after save-match-data.
>>
>> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>> is the call of re-search-forward.
>>
>> I'm not sure this is a sufficient explanation of why save-match-data is
>> needed. Usually in Emacs the caller is responsible for saving the match
>> data, if it needs to. I don't really see the need here.
>
> Can it be removed then?
Probably yes.
> The only perhaps unexpected thing I can think of is that whitespace-cleanup
> can be called from a hook, such as save-file-hook, but that
> doesn't seem to matter.
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Mark Karpov, 2016/12/10
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, npostavs, 2016/12/19
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/20
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/20
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, npostavs, 2016/12/20
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/21
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, npostavs, 2016/12/21
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/22
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore,
npostavs <=
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/23
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, npostavs, 2016/12/24
- bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore, Reuben Thomas, 2016/12/26